tools/tmbench: Bounds checking for txSize.#2410
Merged
melekes merged 1 commit intotendermint:developfrom Sep 17, 2018
WALL-E:develop
Merged
tools/tmbench: Bounds checking for txSize.#2410melekes merged 1 commit intotendermint:developfrom WALL-E:develop
melekes merged 1 commit intotendermint:developfrom
WALL-E:develop
Conversation
ValarDragon
approved these changes
Sep 15, 2018
Contributor
ValarDragon
left a comment
There was a problem hiding this comment.
untested, but looks good to me!
Thanks for the PR!
Contributor
Author
|
update commit: improving test cases |
melekes
suggested changes
Sep 17, 2018
Contributor
melekes
left a comment
There was a problem hiding this comment.
Thanks for contributing to Tendermint!
tools/tm-bench/main.go
Outdated
| if txSize < 40 { | ||
| fmt.Fprintln( | ||
| os.Stderr, | ||
| "txSize must be greater than or equal to 40.", |
Contributor
There was a problem hiding this comment.
The size of a transaction must be ...
Users are not aware of txSize (only tm-bench developers know what txSize is!)
Contributor
Author
|
@melekes I fixed it |
melekes
approved these changes
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2409