Delay starting node until Genesis time#2389
Merged
Conversation
melekes
reviewed
Sep 13, 2018
| now := tmtime.Now() | ||
| genTime := n.genesisDoc.GenesisTime | ||
| if genTime.After(now) { | ||
| time.Sleep(genTime.Sub(now)) |
Contributor
There was a problem hiding this comment.
We should print a message like "Genesis time is in the future. Sleeping until then..."
ValarDragon
reviewed
Sep 13, 2018
|
|
||
| // create & start node | ||
| n, err := DefaultNewNode(config, log.TestingLogger()) | ||
| n.GenesisDoc().GenesisTime = now.Add(5 * time.Second) |
Contributor
There was a problem hiding this comment.
Does this reliably pass for smaller values?
Contributor
Author
There was a problem hiding this comment.
It pass for 10 millisecond.
melekes
approved these changes
Sep 18, 2018
Contributor
|
With this sleep we can't kill the program with SIGINT - see #2434 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2294