Skip to content

docs/spec/abci: improve docs on AppHash#2363

Merged
ebuchman merged 1 commit intodevelopfrom
bucky/doc-app-hash
Sep 10, 2018
Merged

docs/spec/abci: improve docs on AppHash#2363
ebuchman merged 1 commit intodevelopfrom
bucky/doc-app-hash

Conversation

@ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Sep 9, 2018

@codecov-io
Copy link

Codecov Report

Merging #2363 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2363      +/-   ##
===========================================
+ Coverage    60.95%   60.98%   +0.02%     
===========================================
  Files          197      197              
  Lines        16296    16302       +6     
===========================================
+ Hits          9934     9941       +7     
  Misses        5497     5497              
+ Partials       865      864       -1
Impacted Files Coverage Δ
p2p/peer.go 57.95% <0%> (-1.14%) ⬇️
p2p/pex/pex_reactor.go 74% <0%> (-0.34%) ⬇️
consensus/state.go 77.28% <0%> (-0.24%) ⬇️
libs/db/types.go 100% <0%> (ø) ⬆️
node/node.go 65.02% <0%> (+0.27%) ⬆️
consensus/reactor.go 73.82% <0%> (+0.8%) ⬆️

@melekes
Copy link
Contributor

melekes commented Sep 10, 2018

@siman hi! does this PR address your concerns?

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🏎 🍰

@ebuchman ebuchman merged commit 503de8c into develop Sep 10, 2018
@ebuchman ebuchman deleted the bucky/doc-app-hash branch September 10, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants