Merged
Conversation
melekes
approved these changes
Sep 8, 2018
ebuchman
reviewed
Sep 9, 2018
| Requirement|Notes | ||
| ---|--- | ||
| Go version | Go1.9 or higher | ||
| Go version | Go1.10 or higher |
Contributor
There was a problem hiding this comment.
So we actually require 1.10?
Contributor
There was a problem hiding this comment.
I thought so but looks like Tendermint works just fine with 1.9.3.
tm-bench requires 1.10 since it uses new https://golang.org/doc/go1.10#math Round function.
Contributor
There was a problem hiding this comment.
I think we should stick to 1.10, or even consider upgrading to 1.11 around launch time. If so, we can use golang's official xchacha implementation, instead of our own.
Contributor
Author
There was a problem hiding this comment.
i bumped it b/c 1.11 was released & figured we should stay only one version behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2357