Merged
Conversation
Contributor
|
@zramsay can you take a look at this please? |
zramsay
reviewed
Sep 7, 2018
zramsay
reviewed
Sep 7, 2018
zramsay
reviewed
Sep 7, 2018
zramsay
previously requested changes
Sep 7, 2018
Contributor
zramsay
left a comment
There was a problem hiding this comment.
thanks! couple small fixes required
8b03315 to
ba1ef1f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2352 +/- ##
===========================================
- Coverage 61.26% 60.96% -0.31%
===========================================
Files 197 197
Lines 16260 16293 +33
===========================================
- Hits 9962 9933 -29
- Misses 5431 5499 +68
+ Partials 867 861 -6
|
zramsay
reviewed
Sep 8, 2018
remove commit link
Contributor
|
Thanks for contributing @xiaoping378 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.