Major spec update to prepare v0.24.0 for release#2343
Conversation
fix failing website build
Codecov Report
@@ Coverage Diff @@
## develop #2343 +/- ##
===========================================
- Coverage 61.09% 61.05% -0.04%
===========================================
Files 197 197
Lines 16302 16302
===========================================
- Hits 9959 9953 -6
- Misses 5477 5491 +14
+ Partials 866 858 -8
|
|
|
| - `chain_id`: ID of the blockchain. This must be unique for | ||
| every blockchain. If your testnet blockchains do not have unique | ||
| chain IDs, you will have a bad time. The ChainID must be less than 50 bytes. | ||
| chain IDs, you will have a bad time. The ChainID must be less than 50 symbols. |
There was a problem hiding this comment.
Do we allow unicode? Why is it symbols not bytes
There was a problem hiding this comment.
200 bytes (or 50 UTF-8 symbols 4 bytes each)
* better overview section * section on tags * remove notes about state/concurrency from CheckTx * incorporate feedback from #2249 * explain how validator set updates effect future blocks
|
I just pushed a big refactor to the ABCI docs and I'd like to merge it to develop to see it on the staging site - I'll make sure things are basically still functional and then I think we're ready for release. There's still some more feedback to include from #2249 and #2143, but it can happen in hotfixes after the release |
* move spec/software/abci.md to spec/abci/apps.md and improve it * move some of app-dev/app-development.md to spec/abci/client-server.md
| When `Commit` completes, it unlocks the mempool. | ||
|
|
||
| Note that it is not possible to send transactions to Tendermint during `Commit` - if your app | ||
| tries to send a `/broadcast_tx` to Tendermint during Commit, it will deadlock. |
There was a problem hiding this comment.
Is the "deadlock" the right word? I thought if somebody's trying to send tx during Commit, it will wait until lock gets released (X ms.)
tendermint/rpc/core/mempool.go
Line 52 in 22445a5
There was a problem hiding this comment.
If they send the tx from the Commit method itself, it will deadlock since the mempool lock isnt released until we're done CheckTx
| This way the application can determine the initial validator set for the | ||
| blockchain. | ||
|
|
||
| ResponseInitChain also includes ConsensusParams, but these are presently |
There was a problem hiding this comment.
should we link an issue here?
There was a problem hiding this comment.
dont think we have one yet
Opening this against develop to facilitate review.
Still need to update some docs but will tag rc0 now.
Awesome work everyone!