crypto: Remove unnecessary prefixes from amino route variable names#2205
Merged
crypto: Remove unnecessary prefixes from amino route variable names#2205
Conversation
Contributor
you never know. let's add an entry |
4 tasks
Contributor
|
Should also change PubkeyAminoRoute to tendermint/PubkeyMultisigThreshold (ie. multisig first, since then we'll also have PubKeyMultisigWeighted) |
Contributor
|
I got this |
9ac0291 to
fa315fa
Compare
Contributor
|
Should we do the same thing for eg. |
Contributor
Author
|
I was considering that. The reason I didn't change it is that it may make some amino debugging harder. AFAICT, amino prints the struct name, not the path to it. (So you wouldn't see the |
Codecov Report
@@ Coverage Diff @@
## develop #2205 +/- ##
==========================================
- Coverage 62.43% 62.33% -0.1%
==========================================
Files 215 215
Lines 17627 17655 +28
==========================================
Hits 11005 11005
- Misses 5711 5735 +24
- Partials 911 915 +4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REBASE ONTO DEVELOP ONCE #2164 IS MERGED