1417 status response format#1424
Merged
melekes merged 30 commits intotendermint:developfrom Apr 11, 2018
Merged
Conversation
melekes
reviewed
Apr 6, 2018
rpc/core/types/responses.go
Outdated
| ValidatorStatus ValidatorStatus `json:"validator_status,omitempty"` | ||
| NodeInfo p2p.NodeInfo `json:"node_info"` | ||
| SyncInfo SyncInfo `json:"sync_info"` | ||
| ValidatorInfo ValidatorInfo `json:"validator_info,omitempty"` |
Contributor
There was a problem hiding this comment.
remove omitempty. pubkey is always present
melekes
reviewed
Apr 6, 2018
CHANGELOG.md
Outdated
| - Graceful handling/recovery for apps that have non-determinism or fail to halt | ||
| - Graceful handling/recovery for violations of safety, or liveness | ||
|
|
||
| ## Develop |
Contributor
There was a problem hiding this comment.
this needs to be moved to 0.18.0
Contributor
|
🥇 🏎 🍰 |
Contributor
Author
|
Fixed both the changelog and the omit . |
melekes
approved these changes
Apr 9, 2018
Contributor
you'll have to fix p2p tests, sorry |
Contributor
|
needs to be changed to
|
Contributor
|
Also, could you scan the docs/ directory for the same thing? |
Contributor
Author
|
Yes I missed that the json was used in the tests, I'll check out if it's used in other places. |
Codecov Report
@@ Coverage Diff @@
## develop #1424 +/- ##
===========================================
+ Coverage 62.22% 62.24% +0.01%
===========================================
Files 114 114
Lines 11093 11093
===========================================
+ Hits 6903 6905 +2
+ Misses 3547 3546 -1
+ Partials 643 642 -1
|
Contributor
|
Could you please rebase this against latest |
Contributor
Author
|
Do you still want me to put it in the changelog of the 0.18.0 ? It's marked as released for the 6 of April already. |
Contributor
|
0.19.0 |
…rmint into 1417-status-response-format
Contributor
Author
|
Should be rebased properly, data race ruined the test_cover though. |
Contributor
|
Could you please rebase against latest develop? I fixed the data race ( |
melekes
approved these changes
Apr 11, 2018
Contributor
Author
|
Should be alright now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1417