Closed
Conversation
Conflicts: consensus/state.go
consensus/state.go
Outdated
Contributor
There was a problem hiding this comment.
There are none. I meant, "keep it side-effect free"
Contributor
Author
|
ok that cleans up the commits, reverts some of my weirdness, and addVote takes a valIndex (consequently, AddByIndex returns the address). gonna work on evsw and consensus events |
f3ad31d to
6684a54
Compare
Contributor
There was a problem hiding this comment.
Should move into EnterNewRound with boolean timeout=true after condition check, because it didn't necessarily timeout (e.g. it could have gone to commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nilin a round if they haven't seen a POL in that round