I think what we should do is (1) only require glide and (2) install the remaining tools locally using glide (we don't want to install the tools to ~/gopath/bin, that causes other annoyances. And this should not happen automatically w/ make or make install, but require make get_tools.

Otherwise I think it's fine to have a one-liner to install glide, since it's the only one, and its functionality shouldn't change too often.

On a related note, check Masterminds/glide#961 which probably fixes the annoyances we've been having with glide update.

Another related note, I'm experimenting with a docker container to use for development: https://github.com/tendermint/devdoc . Search for 'devdoc' in https://github.com/tendermint/abci/blob/sdk2/Makefile . The usage is:

make devdoc_init
make devdoc // throws you in bash, and you can do things like `make get_tools`
> make get_tools
> make get_protoc
> make get_vendor_deps
> exit
make devdoc_save // saves the last state
make devdoc
> make  // tools and protoc exist.

It's just an experiment. I'm guessing it's not worth it, and that it's better to just enter a docker container with bash and gocode all set up, and just "live" in there, but it's an interesting experiment. Anybody have better ideas for docker development tooling?

The benefit of the above is that it makes it much easier to create a new devdoc instance from scratch, whereas if I just "live" in a docker container for development I'm much more likely to introduce nondeterministic elements in there. The purpose of devdoc save is to cache things. make get_tools and make get_protoc could be baked into the Dockerfile (and only occasionally rebuilt), but there's no good way to cache make get_vendor_deps. We could bind ~/.glide/cache, but that destroys the intent of devdoc which is to help create an isolated environment where only the working directory is exposed.

Deterministic install for tooling #966

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions