-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed as not planned
Closed as not planned
Copy link
Labels
Description
Context
As is currently planned in ABCI++, Tendermint sends the application up to ConsensusParams.Block.MaxBytes - CommitBytes - HeaderBytes - EvidenceBytes of txs. It also sends this number so that applications know the maximum amount of transactions they can return (if they want to add txs or modify them). If applications tend to merge or squash a lot of txs, or they need to filter through and either delay or remove txs, having this limit means they will tend to have undersized blocks.
Proposal
I would instead propose that the application returns the amount of txs (in bytes) it would want in ResponseFinalizeBlock for the following height. This is somewhat similar (mechanically) to how we do pruning using RetainHeight.
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged
- Contributor assigned/self-assigned
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done/Merged