Skip to content

ABCI++: Decide whether Commit should stay out of FinalizeBlock #7659

@sergio-mena

Description

@sergio-mena

Summary

The current code in abci++ branch has Commit outside FinalizeBlock, but the spec assumes Commit is part of Finalizeblock.

Problem Definition

Preliminary inspection of the code seems to suggest Commit should indeed be outside FinalizeBlock, as it is needed to implement Tendermint's crash-recovey mechanism.
Investigate if that is the case and, if so, adapt the spec repo to reflect that.

Dependencies

None


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions