Skip to content

Include consensus settings in block hash #739

@mdyring

Description

@mdyring

Potential bug.

Short version: It seems unclear what happens if nodes in the same network with different (incompatible?) configurations. See @melekes example below.

Maybe these settings should - somehow - be included in the genesis block and be part of the block hash?

Chat log:

mdyring 3:54 PM
odd question of the day: is there any mechanism that forces nodes to run with the same settings (block_interval, create_empty_blocks etc)? i imagine it would be included in one of the hashes somehow, but is that in fact the case?
i guess in the create_empty_blocks case, the block hash will differ and the misconfigured node will get stuck/halt.. and perhaps block_interval is not really a problem to have configured differently?

melekes 12:01 PM
@mdyring interesting question!
I don't think it's reflected in a block hash
I do see one problem however
If one node is configured to produce 1s blocks and 2nd is not (configured with no empty blocks). the fist one will try to propose too often
but will fail because it won't be its turn in 50% of the cases

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions