-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed as not planned
Labels
C:abciComponent: Application Blockchain InterfaceComponent: Application Blockchain InterfaceS:proposalStatus: ProposalStatus: ProposalT:testType: Tests that need loveType: Tests that need lovestalefor use by stalebotfor use by stalebot
Description
Summary
In working on abci updates for lazy ledger and debugging tests I went through updating multiple different abci apps:
- https://github.com/tendermint/tendermint/blob/master/consensus/mempool_test.go#L209
- https://github.com/tendermint/tendermint/blob/master/state/helpers_test.go#L233
- https://github.com/tendermint/tendermint/blob/master/abci/example/counter/counter.go
- https://github.com/tendermint/tendermint/blob/master/abci/example/kvstore/kvstore.go
- https://github.com/tendermint/tendermint/blob/master/abci/example/kvstore/persistent_kvstore.go
- https://github.com/tendermint/tendermint/blob/master/test/e2e/app/app.go
Problem Definition
Too many apps to update and debug. Also, some tests use kvstore others counter and others their own custom counter or kvstore app.
If others don't see this as a problem, custom testing may need custom apps, feel free to close the issue.
Proposal
Use fewer apps and be consistent with what is used in tests.
Using Mockery could be a replacement as well.
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged
- Contributor assigned/self-assigned
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:abciComponent: Application Blockchain InterfaceComponent: Application Blockchain InterfaceS:proposalStatus: ProposalStatus: ProposalT:testType: Tests that need loveType: Tests that need lovestalefor use by stalebotfor use by stalebot