Skip to content

Socket client and server should behave as other Services #486

@melekes

Description

@melekes

tendermint/abci#78 (review)

let's pull the Start method out.

_, err := cli.Start() // Just start it, it's confusing for callers to remember to start.

Is it confusing?
yes

Do any of our other services do that
no

its a Service, you're expected to start it

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:rpcComponent: JSON RPC, gRPC

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions