-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
T:breakingType: Breaking ChangeType: Breaking ChangeT:encodingType: Amino, ProtoBufType: Amino, ProtoBuf
Description
Hashes in Tendermint are currently just slices, not fixed length arrays, so empty hashes (which occur at least in the first block) are encoded differently from others. While it's not hard to handle this currently in Go, it makes for a lot of work in Rust: cometbft/tendermint-rs#66.
Should we consider using fixed-length arrays for hashes and let the "empty hash" be instead the un-initialized array, ie. all 0s?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
T:breakingType: Breaking ChangeType: Breaking ChangeT:encodingType: Amino, ProtoBufType: Amino, ProtoBuf