-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed as not planned
Labels
C:consensusComponent: ConsensusComponent: ConsensusC:syncComponent: Fast Sync, State SyncComponent: Fast Sync, State SyncT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.stalefor use by stalebotfor use by stalebot
Description
It's possible the ConsensusState.Start() returns an error. However, when the BlockchainReactor calls SwitchToConsensus, this error is simply logged and ignored. Since this leaves the node in an unintended state (ie. not participating in consensus), we should probably exit instead, perhaps via panicing.
This is partial follow up to #3295
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:consensusComponent: ConsensusComponent: ConsensusC:syncComponent: Fast Sync, State SyncComponent: Fast Sync, State SyncT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.stalefor use by stalebotfor use by stalebot