-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed as not planned
Labels
C:abciComponent: Application Blockchain InterfaceComponent: Application Blockchain InterfaceT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.T:testType: Tests that need loveType: Tests that need lovestalefor use by stalebotfor use by stalebot
Description
#3067 fixes a long standing issue where ABCI replay of more than 1 block does not work if there is a validator set change.
The TestSimulateValidatorsChange test added to replay_test.go there is quite large and should probably be cleaned up significantly. It should not require going through the entire consensus process just to create blockchain data where the validator set changes over time. Should be much simpler to construct that chain for the tests.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:abciComponent: Application Blockchain InterfaceComponent: Application Blockchain InterfaceT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.T:testType: Tests that need loveType: Tests that need lovestalefor use by stalebotfor use by stalebot