Skip to content

Cleanup replay tests from #3067 #3600

@ebuchman

Description

@ebuchman

#3067 fixes a long standing issue where ABCI replay of more than 1 block does not work if there is a validator set change.

The TestSimulateValidatorsChange test added to replay_test.go there is quite large and should probably be cleaned up significantly. It should not require going through the entire consensus process just to create blockchain data where the validator set changes over time. Should be much simpler to construct that chain for the tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:abciComponent: Application Blockchain InterfaceT:jankType Jank! Non-urgent but still high-impact fixes.T:testType: Tests that need lovestalefor use by stalebot

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions