Skip to content

RPC Client interface does not include NetworkClient #3458

@jacohend

Description

@jacohend

Tendermint version: Master as of commit e0f8936 (0.31.0)

What happened:

As I was making my RPC interface more generic (using client.Client), I found my rpc.NetInfo calls were not compiling. I looked at the source code and found no NetworkClient in the Client interface: https://github.com/tendermint/tendermint/blob/master/rpc/client/interface.go#L72

What you expected to happen:

The Client interface should include the NetworkClient, otherwise full-featured tests and any other usage that swaps out the underlying interface will fail if the user wishes to test/use NetInfo or any other NetworkClient rpc call.

Have you tried the latest version: yes

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions