Skip to content

bug: uninitialized votesets #341

@ebuchman

Description

@ebuchman

The crash/restart tests just caught this bug, related to queryMaj23 logic around existing votesets:

NOTE[12-22|00:41:06] enterNewRound(28/0). Current: 28/0/RoundStepNewHeight module=consensus
NOTE[12-22|00:41:06] enterPrecommit: No +2/3 prevotes during enterPrecommit. Precommitting nil. module=consensus
WARN[12-22|00:41:06] Attempt to finalize failed. We don't have the commit block. module=consensus
NOTE[12-22|00:41:07] Finalizing commit of block with 0 txs    module=consensus height=28 hash=E772057B06DC00560B10384F6C2D9C5F18183E9E root=07F03D501B085AC9BCA8594743DD81B177166A0F
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x4c7444]

goroutine 349 [running]:
panic(0xbb0960, 0xc820012080)
        /usr/local/go/src/runtime/panic.go:481 +0x3e6
github.com/tendermint/tendermint/types.(*VoteSet).TwoThirdsMajority(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x28b90fc01042c00)
        /go/src/github.com/tendermint/tendermint/types/vote_set.go:387 +0x1d4
github.com/tendermint/tendermint/consensus.(*ConsensusReactor).queryMaj23Routine(0xc8201528c0, 0xc82030e460, 0xc8200c2000)
        /go/src/github.com/tendermint/tendermint/consensus/reactor.go:603 +0x24f
created by github.com/tendermint/tendermint/consensus.(*ConsensusReactor).AddPeer
        /go/src/github.com/tendermint/tendermint/consensus/reactor.go:125 +0x1a3

Metadata

Metadata

Assignees

Labels

T:bugType Bug (Confirmed)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions