Skip to content

privval: non-deterministic test failure on TestSocketPVVoteKeepalive #3237

@thanethomson

Description

@thanethomson

Attempting to run make test_cover from develop at present sometimes results in the following test failure emanating from privval/client_test.go:

--- FAIL: TestSocketPVVoteKeepalive (3.45s)
        Error Trace:    client_test.go:182
                        client_test.go:184
        Error:          Received unexpected error:
                        unmarshal to privval.RemoteSignerMsg failed after 4 bytes (unrecognized prefix bytes 48A6160A): 48A6160A5208022A0C088CB7CBE20510A0A0CBD0024240B72B728C333414BD783F5127DCAA67D4561F3C4E76FA55E272207418167F673B68483A8281243C65B5123536715EE4BC2CF6B2E3FF666BEDE4134DFE57E6600904
        Test:           TestSocketPVVoteKeepalive

This first occurred on CircleCI here and was replicated locally by running:

make test_cover

This test, however, does not fail when running:

GOCACHE=off go test -cover -race ./privval
ok  	github.com/tendermint/tendermint/privval	2.766s

Metadata

Metadata

Assignees

No one assigned

    Labels

    T:bugType Bug (Confirmed)T:testType: Tests that need love

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions