-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
good first issueContributions Welcome!!Contributions Welcome!!
Description
Lines 406 to 419 in 4d7b29c
| func (mem *Mempool) resCbRecheck(req *abci.Request, res *abci.Response) { | |
| switch r := res.Value.(type) { | |
| case *abci.Response_CheckTx: | |
| tx := req.GetCheckTx().Tx | |
| memTx := mem.recheckCursor.Value.(*mempoolTx) | |
| if !bytes.Equal(req.GetCheckTx().Tx, memTx.tx) { | |
| cmn.PanicSanity( | |
| fmt.Sprintf( | |
| "Unexpected tx response from proxy during recheck\nExpected %X, got %X", | |
| r.CheckTx.Data, | |
| memTx.tx, | |
| ), | |
| ) | |
| } |
The log
fmt.Sprintf( "Unexpected tx response from proxy during recheck\nExpected %X, got %X", r.CheckTx.Data, memTx.tx, )
is not correct, the expected is the Response while the got is Request which makes the comparison confusing.
I think it can be changed to
fmt.Sprintf( "Unexpected tx response from proxy during recheck\nExpected %X, got %X", req.GetCheckTx().Tx, memTx.tx, )
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueContributions Welcome!!Contributions Welcome!!