Skip to content

merkle: follow up to #2713 #3120

@ebuchman

Description

@ebuchman

See the review for points of follow up: #2713 (review)

The main concern is that Verify now seems to expect an object before it is hashed, so it can prepend the 0-prefix ala the rfc.

However, the leaves of our Merkle trees should always be hashed anyways, even before the 0-prefix is added. @ValarDragon see #2713 (comment)

Few other minor points mentioned in the review.

We're also going to need to update the SDK and possible fix some things in the store pkg, @jackzampolin

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions