Skip to content

Should we hide unroutable node infos in node_info method #3055

@yutianwu

Description

@yutianwu

Hi, we use addr_book_strict for strict address routability rules. but it does not work on rpc method node_info.

For example, if I call node_info, I will get result like that:

{
  "jsonrpc": "2.0",
  "id": "",
  "result": {
    "listening": true,
    "listeners": [
      "Listener(@172.22.43.12:26656)"
    ],
    "n_peers": "1",
    "peers": [
      {
        "node_info": {
          "id": "3b62301c30805155d1e57abfc8b86c47ecd9453f",
          "listen_addr": "172.22.41.138:26656",
          "network": "chain-test",
          "version": "0.25.1",
          "channels": "40202122233038",
          "moniker": "test",
          "other": {
            "amino_version": "0.12.0",
            "p2p_version": "0.5.0",
            "consensus_version": "v1/0.2.2",
            "rpc_version": "0.7.0/3",
            "tx_index": "off",
            "rpc_address": "tcp://0.0.0.0:26657"
          }
        },
        "is_outbound": true,
        ....
  }
}

can we hide unroutable nodes, it may be unsafe to expose private nodes to public.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:p2pComponent: P2P pkgC:rpcComponent: JSON RPC, gRPCS:proposalStatus: Proposalstalefor use by stalebot

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions