Skip to content

MConnConfig doesn't take effect because transport use the default #2842

@yutianwu

Description

@yutianwu

hi, recently, I found that the blocking time increases dramatically even in local testnet.

It cost me one whole day to track it down... It turns out that transport does not use the MConnConfig.

transport = p2p.NewMultiplexTransport(nodeInfo, *nodeKey)

but we use the MConnConfig in Switch.

tendermint/p2p/switch.go

Lines 105 to 111 in 6353862

mConfig := conn.DefaultMConnConfig()
mConfig.FlushThrottle = cfg.FlushThrottleTimeout
mConfig.SendRate = cfg.SendRate
mConfig.RecvRate = cfg.RecvRate
mConfig.MaxPacketMsgPayloadSize = cfg.MaxPacketMsgPayloadSize
sw.mConfig = mConfig

but the config in Switch does not take effect actually.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:p2pComponent: P2P pkgT:bugType Bug (Confirmed)

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions