consensus: non-deterministic test failure #2680
Description
Perhaps we're not shutting down a switch correctly
--- FAIL: TestReactorValidatorSetChanges (0.15s)
panic: listen tcp 127.0.0.1:4182: bind: address already in use [recovered]
panic: listen tcp 127.0.0.1:4182: bind: address already in use
goroutine 7477 [running]:
testing.tRunner.func1(0xc4214a9ef0)
/usr/local/go/src/testing/testing.go:742 +0x567
panic(0xf51260, 0xc424c99ef0)
/usr/local/go/src/runtime/panic.go:502 +0x24a
github.com/tendermint/tendermint/p2p.MakeSwitch(0xc4202248c0, 0x0, 0x102c997, 0x9, 0x102d928, 0xb, 0xc42189f878, 0x0, 0x0, 0x0, ...)
/go/src/github.com/tendermint/tendermint/p2p/test_util.go:182 +0xc71
github.com/tendermint/tendermint/p2p.MakeConnectedSwitches(0xc4202248c0, 0x7, 0xc42189f878, 0x1182e60, 0x0, 0x0, 0x0)
/go/src/github.com/tendermint/tendermint/p2p/test_util.go:75 +0x10c
github.com/tendermint/tendermint/consensus.startConsensusNet(0xc4214a9ef0, 0xc4213b36c0, 0x7, 0x7, 0x7, 0x1182d18, 0xc4213b36c0, 0x7, 0x7, 0xc4228bdd00, ...)
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:56 +0x6aa
github.com/tendermint/tendermint/consensus.TestReactorValidatorSetChanges(0xc4214a9ef0)
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:339 +0x113
testing.tRunner(0xc4214a9ef0, 0x1182c10)
/usr/local/go/src/testing/testing.go:777 +0x16e
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:824 +0x565
FAIL github.com/tendermint/tendermint/consensus 4.409s
Exited with code 1