Skip to content

rs.LastCommit should be rs.LastVotes (HeightVoteSet) #262

@jaekwon

Description

@jaekwon

Since the first known commit round could differ from node to node, in order to make LastCommit work best, we should really keep track of not just our subjective last commit round, but other rounds as well (e.g. the whole HeightVoteSet), so that when a peer's subjective last commit round is R, we can send it additional votes for R. The current behavior is that we don't send any additional LastCommit votes if our subjective commit rounds differ.

Or, we might think of other mechanisms for auto-inactivating validators that doesn't solely on the blockchain's Commits.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions