-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
C:libsComponent: LibraryComponent: LibraryT:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.General cleanup and restructuring of code to provide clarity, flexibility, and modularity.T:enhancementType: EnhancementType: Enhancement
Milestone
Description
It is quite conventional in the UNIX world to return 128 + signal code upon exit due to a signal, so I'd suggest TrapSignal() call os.Exit(128 + int($signalcode)) instead of os.Exit(1)
Tendermint version: develop
ABCI app: Gaia
Environment: Ubuntu 18.04
CC'ing @jaekwon, who appears to be the original author of the function.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:libsComponent: LibraryComponent: LibraryT:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.General cleanup and restructuring of code to provide clarity, flexibility, and modularity.T:enhancementType: EnhancementType: Enhancement