-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
C:consensusComponent: ConsensusComponent: ConsensusC:p2pComponent: P2P pkgComponent: P2P pkgT:bugType Bug (Confirmed)Type Bug (Confirmed)
Milestone
Description
In consensus/state.go, cs.defaultSetProposal could return a ErrInvalidProposalSignature error, but cs.handleMsg only catches that with a cs.Logger.Error message and it appears the block can still be committed. Where are invalid proposal signatures caught and blocked? Are they not a concern? Thanks!
Note: I'm looking at a downlevel master branch, but it looks like the latest master has the same logic.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:consensusComponent: ConsensusComponent: ConsensusC:p2pComponent: P2P pkgComponent: P2P pkgT:bugType Bug (Confirmed)Type Bug (Confirmed)