Skip to content

p2p: process handshakes asynchronously #2047

@ebuchman

Description

@ebuchman

Reported by an auditor.

New connections are currently accepted synchronously, so any new connection must wait until the last one is setup before it can start. This may allow an attacker to prevent a node from acquiring new peers.

We should also check and reject connections from duplicate IPs right away, rather than waiting for after the handshake.

Metadata

Metadata

Assignees

Labels

C:p2pComponent: P2P pkgT:securityType: Security (specify priority)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions