Skip to content

consensus: remove MaxTxs for MaxBytes #2035

@ebuchman

Description

@ebuchman

We currently use MaxTxs to reap txs from the mempool when proposing a block, but enforce MaxBytes when unmarshalling a block, so we could easily propose a block thats too large to be valid.

We should probably just remove MaxTxs all together and stick with MaxBytes, and have a mempool.ReapBytes

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:consensusComponent: ConsensusT:bugType Bug (Confirmed)

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions