Skip to content

abci: update proto/grpc and fix KVPair errors #1944

@ebuchman

Description

@ebuchman

We are currently pinned to a revision of genproto which causes issues with importing Tendermint, ie. #1777

We can remove this error and the need to version the genproto by updating protobuf to v1.1.0, but then our grpc test fail with:

--- FAIL: TestBroadcastTx (0.01s)
panic: message/group field common.KVPair:bytes without pointer [recovered]
        panic: message/group field common.KVPair:bytes without pointer

 ...

 github.com/tendermint/tendermint/rpc/grpc_test.TestBroadcastTx(0xc420a5ab40)
         /go/src/github.com/tendermint/tendermint/rpc/grpc/grpc_test.go:29 +0x141

We also get some erroneous output (#1853) that looks like:

proto: no slice oenc for *reflect.rtype = []*reflect.rtype
proto: no encoder for Tags []common.KVPair [GetProperties]

Perhaps the two problems are related. Using this issue to replace the others.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:abciComponent: Application Blockchain InterfaceT:bugType Bug (Confirmed)good first issueContributions Welcome!!

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions