Skip to content

abci: use EndBlock to control empty block creation #1909

@ebuchman

Description

@ebuchman

Since some apps will change the app hash every block, even with empty blocks, setting create_empty_blocks=false won't achieve anything.

To solve this, we could add a Pause bool field to ResponseEndBlock that tells Tendermint whether to make a new block right away or not.

We should write a proper ADR before making this change. Note that any state transitions that occur in the last block committed will not have light-client proofs until the next block is committed, so apps need to be careful when setting Pause=true

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:abciComponent: Application Blockchain InterfaceC:consensusComponent: ConsensusT:enhancementType: Enhancementstalefor use by stalebot

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions