This repository was archived by the owner on Feb 23, 2022. It is now read-only.
Revert "proto: abci++ changes (#348)"#360
Merged
williambanfield merged 1 commit intomasterfrom Nov 16, 2021
Merged
Conversation
This reverts commit caaafc4.
creachadair
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit caaafc4.
We don't currently have a version strategy that allows us to make this kind of breaking change. I'd like to reorder this commit to be after the updates to the build system so that I have a commit that builds stably against current tendermint.
Related, it appears that, when running the new proto tooling, a type is missing that is used in ABCI++. It references a
VoteExtensiontype that is not defined: https://github.com/tendermint/spec/pull/360/files#diff-8384a26745c978d00d66edad2513d2c0518fab0ddb4123c613f475b88ed95667L302