This repository was archived by the owner on Feb 23, 2022. It is now read-only.
Merged
Conversation
cmwaters
approved these changes
May 12, 2021
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
LGTM 👍
If a genesis file is greater than the size of one chunk then calling /genesis will return an error right? Do we also want to include a note of this in the Genesis section
alexanderbez
approved these changes
May 12, 2021
Contributor
Author
|
I have not changed the behavior of the genesis endpoint, yet, but we could do that. |
cmwaters
approved these changes
May 12, 2021
tac0turtle
approved these changes
May 17, 2021
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
thanks for making this change
Contributor
|
@tychoish can you fix the linter and then we can merge this |
Contributor
|
@tychoish can you fix the linting in this PR. Then we can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reflects the changes in: tendermint/tendermint#6445