This repository was archived by the owner on Feb 23, 2022. It is now read-only.
abci: add abci_version to requestInfo#223
Merged
tac0turtle merged 2 commits intomasterfrom Nov 24, 2020
Merged
Conversation
melekes
approved these changes
Nov 24, 2020
spec/abci/abci.md
Outdated
| - `Version (string)`: The Tendermint software semantic version | ||
| - `BlockVersion (uint64)`: The Tendermint Block Protocol version | ||
| - `P2PVersion (uint64)`: The Tendermint P2P Protocol version | ||
| - `AbciVersion (string)`: The Tendermint ABCI semantic version |
Contributor
There was a problem hiding this comment.
We should specify what "semantic version" actually means, I don't see any description of it anywhere in the spec.
Contributor
There was a problem hiding this comment.
Also, shouldn't it be ABCIVersion, not AbciVersion? Similar to ChainID, not ChainId.
Contributor
Author
There was a problem hiding this comment.
I left it as it would be generated in go without gogoproto. I changed it to ABCI.
erikgrinaker
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.