Skip to content
This repository was archived by the owner on Jul 15, 2018. It is now read-only.
This repository was archived by the owner on Jul 15, 2018. It is now read-only.

Dependency on go-amino for generating addresses #77

@amrali

Description

@amrali

On update-go-amino branch there's this code

bz, err := cdc.MarshalBinary(pubKey)
and similar code on the master branch.

In TM core the PrivValidatorFS struct depends on PubKeyEd25519.Address method to get an address, using amino.MarshalBinary effectively makes the address generation process dependent on go-amino. Is this intentional? Shouldn't marshalling data be reserved for communication across the wire or for serialization on disk?

Pain: I wasted hours trying to figure out why my ripemd160 hash of append([]byte{TypeEd25519}, pubkey...) doesn't match the address fixture for public keys in unit tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions