bugfix: fields with tag "write_empty" are not marshaled correctly#287
Merged
zmanian merged 1 commit intotendermint:masterfrom Sep 12, 2019
Merged
bugfix: fields with tag "write_empty" are not marshaled correctly#287zmanian merged 1 commit intotendermint:masterfrom
zmanian merged 1 commit intotendermint:masterfrom
Conversation
Contributor
Author
|
btw, I submitted a report to the bug bounty program |
golangcibot
reviewed
Sep 8, 2019
2b9d1b2 to
b49e568
Compare
Contributor
|
We should consider back porting this fix to @rickyyangz is this bug blocking you? |
zmanian
approved these changes
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the titled described, the implementation of write_empty is not correct, fields with write_empty tag may still be marshaled to empty bytes.
the result is