This repository was archived by the owner on Feb 2, 2019. It is now read-only.
Add a verify method that also takes an uncompressed public key#8
Closed
ValarDragon wants to merge 1 commit intotendermint:masterfrom
Closed
Add a verify method that also takes an uncompressed public key#8ValarDragon wants to merge 1 commit intotendermint:masterfrom
ValarDragon wants to merge 1 commit intotendermint:masterfrom
Conversation
(cherry picked from commit 2ab46c5)
liamsi
reviewed
Jun 19, 2018
|
|
||
| // VerifyUncompressedKey returns true iff sig is a valid signature of message by publicKey. | ||
| // This takes in the uncompressed form of the public key (A) to avoid computing that internally. | ||
| func VerifyUncompressedKey(publicKey *[PublicKeySize]byte, A *edwards25519.ExtendedGroupElement, message []byte, sig *[SignatureSize]byte) bool { |
There was a problem hiding this comment.
Also, as this interna become public now, it would be good to point to the section in the paper that deals with the compressed/uncompressed key. Such that a user who is expecting a API ala Sign/Verify can learn why this is different here.
Author
|
repo abandoned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #7. Commit is (cherry picked from commit 2ab46c5) in #7.
A verification method using the uncompressed pubkey is useful for the proof of stake use case, since we often validate multiple signatures from the same public key. Based off of the numbers in the official Ed25519 paper, the function with the uncompressed pubkey should save about 10% of the computation time.