This repository was archived by the owner on Jul 15, 2018. It is now read-only.
Merged
Conversation
Contributor
zramsay
commented
Oct 23, 2017
- closes abci-cli console produces empty output for some commands #75, Abci-cli doesn't return output on check_tx or deliver_tx #93
zramsay
commented
Oct 23, 2017
| func cmdConsole(cmd *cobra.Command, args []string) { | ||
|
|
||
| for { | ||
| fmt.Printf("\n> ") |
Contributor
Author
There was a problem hiding this comment.
the extra line is not necessary IMO and makes for a less nice experience because we end up with double line breaks
zramsay
commented
Oct 23, 2017
| if !rsp.Code.IsOK() { | ||
| fmt.Printf("-> code: %s\n", rsp.Code.String()) | ||
| } | ||
| // Always print the status code. |
Contributor
Author
There was a problem hiding this comment.
how the docs had it. it's a good verification that things worked
zramsay
commented
Oct 23, 2017
| if cmd.Use != "commit" { | ||
| fmt.Printf("-> data: %s\n", rsp.Data) | ||
| } | ||
| fmt.Printf("-> data.hex: 0x%X\n", rsp.Data) |
Contributor
Author
There was a problem hiding this comment.
append 0x because that's how the docs are. maybe it got removed for a reason but IMO with is nicer
zramsay
commented
Oct 23, 2017
| -> data.hex: 0x7B2273697A65223A317D | ||
|
|
||
| > commit | ||
| -> data: I��\ͬޮ�(����h���� |
Contributor
Author
There was a problem hiding this comment.
uhmm, ya this was the test.
melekes
approved these changes
Oct 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.