Fix RX filter flag showing 0.1 kHz less than selected preset (#794)#881
Merged
Merged
Conversation
…dr#794) For SSB-like modes (USB/LSB/DIGU/DIGL/FDV), display the nominal filter edge value (hi-cut or abs(lo-cut)) instead of the passband width (hi - lo), which was 95 Hz less due to the intentional low-cut offset. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #794
hi - lo, which was 95 Hz less due to the intentional 95 Hz low-cut offsetVfoWidget::updateFilterLabel()andRxApplet::formatFilterWidth()with mode-aware width calculationDetails
When selecting a preset RX filter (e.g. 2.7K), the radio sets
lo=95, hi=2700(USB) orlo=-2700, hi=-95(LSB). The old code displayedhi - lo = 2605, which rounds to "2.6K" — 0.1 kHz less than the selected "2.7K" preset. The fix displays the filter edge value directly (2700 → "2.7K"), matching SmartSDR behavior.CW/AM/SAM/DSB/RTTY modes are unaffected (symmetric filters where
hi - lois already correct).Files changed
src/gui/VfoWidget.cppupdateFilterLabel(), refresh on mode changesrc/gui/RxApplet.cppformatFilterWidth(), pass mode to callers, refresh on mode changesrc/gui/RxApplet.hmodeparameter toformatFilterWidth()Test plan
🤖 Generated with Claude Code