Merged
Conversation
9 tasks
stephanos
approved these changes
Dec 6, 2024
tests/query_workflow_test.go
Outdated
Contributor
There was a problem hiding this comment.
Could you add a small comment explaining the purpose of the second half of the test? I don't quite see the difference to the first half.
ychebotarev
approved these changes
Dec 6, 2024
ychebotarev
approved these changes
Dec 6, 2024
tests/query_workflow_test.go
Outdated
Contributor
There was a problem hiding this comment.
q: why not just a single test, with both "QueryWorkflow" and "PollWorkflowTaskQueue/RespondQueryTaskCompleted" in a separate goroutines? What are you testing by testing like that?
Member
Author
There was a problem hiding this comment.
I only need two concurrent routines, so I'm using the test routine as one of those.
bergundy
commented
Dec 6, 2024
Member
Author
bergundy
left a comment
There was a problem hiding this comment.
Thanks for the reviews.
I'll add more comments to clarify.
e65fab2 to
9bdca0f
Compare
9bdca0f to
0fb8952
Compare
0fb8952 to
7cb03ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Attach a Failure object from query failures to the QueryFailure serviceerror.
Why?
Allows encryption of failure messages and stack traces.
See also temporalio/api/pull/503.