Clarify WithTags behaviour in metrics handler#1975
Merged
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom Jun 23, 2025
Merged
Clarify WithTags behaviour in metrics handler#1975Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Conversation
Contributor
Author
|
Failures may be flaky? I only updated documentation |
This explicitly states how WithTags should work with existing tags on the handler.
d19b7cf to
4c8b172
Compare
Quinn-With-Two-Ns
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicitly states how WithTags should work with existing tags on the handler.
What was changed
Documentation only for the metrics handler interface.
Why?
I had implemented a custom handler and had a hard time figuring out why some tags I needed for alerting were missing. See slack thread.
Checklist
Closes
How was this tested:
Not needed
Any docs updates needed?
Not sure as I don't remember seeing this in the documentation. Honestly I figured it out by looking at how the uber-go/tally package implements it and asking on slack. I think having it in the metrics handler interface is good enough but let me know if you also want it included somewhere in the documentation.