Conversation
… mostly flag definitions
…, would be nice to avoid having to strip the "worker-" prefix when passing args to worker start command
|
FWIW @Sushisource , we can't just pass flags through to plumb this, the metric line contains state from both the scenario runner & worker, but they'll be running in separate processes, and in cloud, separate vms. The prom instance already has the address of the worker, I want to add an I also want to separate
LMK if this makes sense and I'll have the PR up |
1faa3c1 to
201fc64
Compare
Is this just for reporting it with the tests? Shouldn't we know already because we set it? (I'm not necessarily opposed, just asking). The separation of types makes sense to me |
Yes - it'd be for reporting, but I can see the client having worker config/info being useful generally. If we spawn the worker and client in separate processes, their configurations are not provided to each other. |
What was changed
Minor cleanup/code movement and adding additional fields to
MetricLine.Added fields still need to be plumbed through (will be empty for now):
Environment: environment that the scenario was run fromBuildID: build ID of the workerScenario: scenario nameRunConfigProfile: profile name of the run configurationWorkerConfigProfile: profile name of the worker configurationwhere a
profilemaps to a configuration.Want some feedback to establish the metrics schema. The goal is to have a schema we anticipate to not have to change.
Plumbing to come in a subsequent PR (in progress, will link).
Why?
Allows us to filter queries on more parameters that will be useful.
Establish the schema for the data team to create omni topics for.