Skip to content

v3.1.9#886

Merged
sonvnn merged 31 commits intomasterfrom
v3
Dec 16, 2024
Merged

v3.1.9#886
sonvnn merged 31 commits intomasterfrom
v3

Conversation

@sonvnn
Copy link
Copy Markdown
Member

@sonvnn sonvnn commented Nov 26, 2024

No description provided.

@sonvnn sonvnn added this to the Version 3.1.9 milestone Nov 26, 2024
@sonvnn sonvnn linked an issue Nov 27, 2024 that may be closed by this pull request
@sonvnn sonvnn linked an issue Nov 29, 2024 that may be closed by this pull request
@sonvnn sonvnn requested a review from felixkat November 29, 2024 08:55
Copy link
Copy Markdown
Member Author

@sonvnn sonvnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixkat Please help me review this code. If it's work please help me approve this with comment.
Thanks,
Sonny

@sonvnn sonvnn requested a review from rinka88 November 29, 2024 08:57
Copy link
Copy Markdown
Member Author

@sonvnn sonvnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rinka88 Please help me review load Single module feature. If this works, please help me approve this review

@rinka88
Copy link
Copy Markdown

rinka88 commented Nov 29, 2024

@rinka88Пожалуйста, помогите мне просмотреть функцию «Загрузить один модуль». Если это работает, пожалуйста, помогите мне одобрить этот обзор

Module selection works fine. Modules are displayed on the site. I just noticed that the Style Module is not used in both cases. And in positions and module selection. And how do I approve a review?

@sonvnn
Copy link
Copy Markdown
Member Author

sonvnn commented Nov 29, 2024

@rinka88Пожалуйста, помогите мне просмотреть функцию «Загрузить один модуль». Если это работает, пожалуйста, помогите мне одобрить этот обзор

Module selection works fine. Modules are displayed on the site. I just noticed that the Style Module is not used in both cases. And in positions and module selection. And how do I approve a review?

Submit a review and approve here
Screen Shot 2024-11-29 at 16 27 35

@rinka88 rinka88 closed this Nov 29, 2024
@rinka88 rinka88 reopened this Nov 29, 2024
Copy link
Copy Markdown

@felixkat felixkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I have tested so far is all working.

Copy link
Copy Markdown

@rinka88 rinka88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works. Great.

@sonvnn
Copy link
Copy Markdown
Member Author

sonvnn commented Nov 29, 2024

@rinka88 you have to select approve radiobox to approve this.

Copy link
Copy Markdown

@rinka88 rinka88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works. Great.

@sonvnn sonvnn linked an issue Dec 4, 2024 that may be closed by this pull request
@C-G-White
Copy link
Copy Markdown

Sonvnn, sorry but this is my first time using the commenting / review system on Github having reported the issue. Where do I download the updated version 3.1.9? I am damned if I can see the place to download it!!! All the best. Regards, Chris.

Copy link
Copy Markdown

@C-G-White C-G-White left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi this has fixed the issue with the menu dropdown.

@sonvnn sonvnn linked an issue Dec 11, 2024 that may be closed by this pull request
@WM-Loose
Copy link
Copy Markdown

WM-Loose commented Dec 11, 2024

With 3.1.9 the following errors appear when you open your own module in the frontend and then click save:

1
2
3

If I go back to 3.1.8 everything is fine.
I had that before but you couldn't reproduce it Sonny.

@sonvnn
Copy link
Copy Markdown
Member Author

sonvnn commented Dec 11, 2024

With 3.1.9 the following errors appear when you open your own module in the frontend and then click save:

1 2 3

If I go back to 3.1.8 everything is fine. I had that before but you couldn't reproduce it Sonny.

I fixed this issue on 711578b
Please download v3-branch and retest again.

@WM-Loose
Copy link
Copy Markdown

It works now vith v3-branch.

@sonvnn sonvnn merged commit e33e8d3 into master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

5 participants