Skip to content

Translation: Updated mod_astroid_clear_cache#883

Merged
sonvnn merged 2 commits intotemplaza:masterfrom
YGomiero:master
Nov 26, 2024
Merged

Translation: Updated mod_astroid_clear_cache#883
sonvnn merged 2 commits intotemplaza:masterfrom
YGomiero:master

Conversation

@YGomiero
Copy link
Copy Markdown
Contributor

@YGomiero YGomiero commented Nov 26, 2024

Enhancing Translation Support with Extended JavaScript Integration

While working on an in-depth translation, I identified several elements, particularly in JavaScript, that are not currently available for translation. This limits the multilingual experience and leaves room for improvement in the internationalization of the extension.
Proposed Changes

  • Extended Translation Coverage: Added missing strings, especially for JavaScript elements, using Joomla\CMS\Language\Text.
    
  • Code Refactoring: Replaced JText with Joomla\CMS\Language\Text to align with Joomla 4 best practices.
    
  • Suggestions for Future Improvements:
       Centralize all translation strings used in JavaScript for better management.
       Establish a clear structure in language files to identify JavaScript-specific strings.
    

Appreciation

I want to express my gratitude to the lead developer for their outstanding work on this framework. Their efforts have laid a strong foundation, making enhancements like this possible. This contribution aims to complement and further improve the existing functionality.
Benefits

Significant improvement in translation handling.

  • Comprehensive support for multilingual elements, including JavaScript interactions.
  • Better preparation for environments requiring robust internationalization.

Testing Instructions

Review updated language files for added translation strings.
Test JavaScript interactions to ensure translated strings are correctly displayed.
Verify that previously missing strings are now covered.

Updated mod_astroid_clear_cache to use Joomla\CMS\Language\Text
Copy link
Copy Markdown
Member

@sonvnn sonvnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successful!
Joomla 5.2.1
Astroid 3.1.8

@sonvnn sonvnn merged commit 0da97c4 into templaza:master Nov 26, 2024
@sonvnn
Copy link
Copy Markdown
Member

sonvnn commented Nov 26, 2024

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants