Add options to switch off \ on Slideshow indicators and controls#869
Merged
sonvnn merged 12 commits intotemplaza:v3from Nov 18, 2024
felixkat:v3
Merged
Add options to switch off \ on Slideshow indicators and controls#869sonvnn merged 12 commits intotemplaza:v3from felixkat:v3
sonvnn merged 12 commits intotemplaza:v3from
felixkat:v3
Conversation
Version 3.1.6
Member
|
Thank you for your contribute. I will be running a marathon this Sunday, so I will review and approve these changes next Monday. |
sonvnn
approved these changes
Nov 18, 2024
Member
There was a problem hiding this comment.
I think in the line 120. You should use $checked instead of checked. It will raise the PHP error
Author
There was a problem hiding this comment.
Yes, sorry, bad copy and paste. 😉
Member
There was a problem hiding this comment.
Line 92: use $params->get('indicators', 1) instead of $indicators
Line 124: use $params->get('controls', 1) instead of $controls
Member
There was a problem hiding this comment.
Can you merge this with the latest one in https://github.com/templaza/astroid-framework/blob/v3/framework/elements/formbuilder/ajax.php? I fixed #867 on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add options to switch off \ on Slideshow indicators and controls
Also minor bug with widget ordering