Default value for $this->params->get('sass_overrides'#523
Merged
sonvnn merged 1 commit intotemplaza:masterfrom Jan 2, 2024
GHSVS-de:patch-1
Merged
Default value for $this->params->get('sass_overrides'#523sonvnn merged 1 commit intotemplaza:masterfrom GHSVS-de:patch-1
sonvnn merged 1 commit intotemplaza:masterfrom
GHSVS-de:patch-1
Conversation
With PHP8.2 message `json_decode(): Passing null to parameter #1 ($json) of type string is deprecated`.
sonvnn
approved these changes
Jan 2, 2024
Member
sonvnn
left a comment
There was a problem hiding this comment.
Thank you for contribute. I approve this request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PHP8.2 message
json_decode(): Passing null to parameter #1 ($json) of type string is deprecated.We are using an astroid template where the settings for sass overrides are deactivated in the template style.
Therefore the line
$sass_overrides = $this->params->get('sass_overrides');produces a deprecated message in the following line because
$sass_overrides === null$sass_overrides = \json_decode($sass_overrides, true);==>
json_decode(): Passing null to parameter #1 ($json) of type string is deprecated.This PR adds a default value
'{}'as fallback when $sass_overrides === null. It doesn't change the functionality of the method because json_decode() now returns an empty array.