feat(event-bus)!: support enum events in EventBus::listen()#1878
Merged
brendt merged 1 commit intotempestphp:3.xfrom Jan 9, 2026
Merged
feat(event-bus)!: support enum events in EventBus::listen()#1878brendt merged 1 commit intotempestphp:3.xfrom
EventBus::listen()#1878brendt merged 1 commit intotempestphp:3.xfrom
Conversation
0902102 to
c948e60
Compare
Currently when attempting to listen to a enum event, such as `KernelEvent` with
an ad-hoc listener, one needs to manually construct the event key that is
generated internally in `GenericEventBus::resolveHandlers()`, which is fragile:
$bus->listen(…, KernelEvent::class . '::' . KernelEvent::SHUTDOWN->name);
Support taking a UnitEnum directly, which is already supported for the
`EventHandler` attribute.
c948e60 to
9f7c2d6
Compare
EventBus::listen()EventBus::listen()
EventBus::listen()EventBus::listen()
innocenzi
approved these changes
Jan 8, 2026
EventBus::listen()EventBus::listen()
Member
|
Very nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when attempting to listen to a enum event, such as
KernelEventwith an ad-hoc listener, one needs to manually construct the event key that is generated internally inGenericEventBus::resolveHandlers(), which is fragile:Support taking a UnitEnum directly, which is already supported for the
EventHandlerattribute.