feat(core)!: make Environment its own source of truth#1838
Merged
Conversation
Member
Author
|
Actually, I think there is an opportunity to refactor the environment outside of |
4ad4f55 to
e741d32
Compare
Environment initializerEnvironment its own source of truth
Environment its own source of truthEnvironment its own source of truth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because injecting
Environmentis more discoverable and a better DX than injectingAppConfig.EDIT: so actually, as specified in my comment below, I completely dissociated
AppConfigfromEnvironment:Environment::fromEnvindirectly throughAppConfig's constructor when resolved from the containerenvironmentproperty of theAppConfigin userland will not behave as expected due to thatEnvironmentis its own source of truth in the container, it's even easier to spoof in tests